Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(extra-natives/five): implement [GET/SET]_GLOBAL_PASSENGER_MASS_MULTIPLIER #2796

Closed
wants to merge 4 commits into from
Closed

feat(extra-natives/five): implement [GET/SET]_GLOBAL_PASSENGER_MASS_MULTIPLIER #2796

wants to merge 4 commits into from

Conversation

Explooosion-code
Copy link
Contributor

@Explooosion-code Explooosion-code commented Sep 17, 2024 •
edited
Loading

Goal of this PR

Adding a getter and setter to control the mass of passengers. I.E if you have a racing server you might want to have passengers not decrease performance of vehicle and you might want to

 SetGlobalPassengerMassMultiplier(0.0)

...

How is this PR achieving the goal

By setting/getting the value that GTA is using for decreasing performance of vehicle depending on passenger count

...

This PR applies to the following area(s)

Fivem, Extra Natives

...

Successfully tested on

Game builds: 1604, 2060, 2189, 3095, 3258

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@qalle-git
Copy link

yes, please

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Sep 17, 2024
@prikolium-cfx
Copy link
Contributor

Hi. Can you please rename natives to SET/GET_GLOBAL_PASSENGER_MASS_MULTIPLIER and also you need to reset it on disconnect from the server in OnKillNetwork to its default value. You can check how our custom natives work now.

@prikolium-cfx prikolium-cfx added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Sep 19, 2024
@Explooosion-code Explooosion-code changed the title feat(extra-natives/five): implement [GET/SET]_PASSENGER_WEIGHT feat(extra-natives/five): implement [GET/SET]_GLOBAL_PASSENGER_MASS_MULTIPLIER Sep 19, 2024
@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged triage Needs a preliminary assessment to determine the urgency and required action and removed triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged labels Sep 19, 2024
@Explooosion-code
tweak(extra-natives/five): Change native name: PASSENGER_WEIGHT -> GL…
341dcc5 
…OBAL_PASSENGER_MASS_MULTIPLIER

tweak(native-docs): Add information aboud default value

feat(extra-natives/five): Reset passenger mass OnKillNetwork

tweak(extra-natives/five): Change native name PASSENGER_WEIGHT -> GLOBAL_PASSENGER_MASS_MULTIPLIER
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed invalid Requires changes before it's considered valid and can be (re)triaged triage Needs a preliminary assessment to determine the urgency and required action labels Sep 19, 2024
@prikolium-cfx prikolium-cfx added ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Sep 19, 2024
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Sep 19, 2024
@prikolium-cfx
Copy link
Contributor

Rebased and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PsychoShock PsychoShock PsychoShock left review comments

@prikolium-cfx prikolium-cfx prikolium-cfx approved these changes

Assignees
No one assigned
Labels
invalid Requires changes before it's considered valid and can be (re)triaged ready-to-merge This PR is enqueued for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Explooosion-code @qalle-git @prikolium-cfx @PsychoShock