Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clr/shared): remove preprocessor stuff for Object #2737

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(clr/shared): remove preprocessor stuff for Object #2737

merged 1 commit into from
Oct 3, 2024

Conversation

AvarianKnight
Copy link
Contributor

As of #2731 this is no longer needed.

Goal of this PR

Allow rt2 to properly take Prop for GetGamePool

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: ..

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Aug 20, 2024
@FabianTerhorst FabianTerhorst self-assigned this Aug 26, 2024
FabianTerhorst
FabianTerhorst approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@FabianTerhorst FabianTerhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@FabianTerhorst FabianTerhorst added ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Sep 27, 2024
@FabianTerhorst FabianTerhorst mentioned this pull request Sep 27, 2024
Merged
4 tasks
@prikolium-cfx prikolium-cfx merged commit 68c0c36 into citizenfx:master Oct 3, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianTerhorst FabianTerhorst FabianTerhorst approved these changes

Assignees

@FabianTerhorst FabianTerhorst

Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AvarianKnight @FabianTerhorst @prikolium-cfx