Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new valid Epic installation path for gameselect process #2730

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add new valid Epic installation path for gameselect process #2730

merged 1 commit into from
Sep 9, 2024

Conversation

Mathu-lmn
Copy link
Contributor

Goal of this PR

This PR adds a new path for Epic games installation for the game selection process. As we've got more issues about wrong IVPath in the discord guild recently

How is this PR achieving the goal

Adds another "folderAttempt" entry with a recent valid Epic games Registry value, see :
image

This PR applies to the following area(s)

FiveM

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@Mathu-lmn Mathu-lmn changed the title tweak(gameselect): add new valid Epic installation path Add new valid Epic installation path for gameselect process Aug 19, 2024
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Aug 19, 2024
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed invalid Requires changes before it's considered valid and can be (re)triaged triage Needs a preliminary assessment to determine the urgency and required action labels Aug 21, 2024
@Nobelium-cfx Nobelium-cfx added enhancement Feature or other request that adds functionality or improved usability ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Sep 6, 2024
@prikolium-cfx prikolium-cfx merged commit 33bba1c into citizenfx:master Sep 9, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nobelium-cfx Nobelium-cfx Nobelium-cfx approved these changes

@FabianTerhorst FabianTerhorst Awaiting requested review from FabianTerhorst

Assignees
No one assigned
Labels
enhancement Feature or other request that adds functionality or improved usability ready-to-merge This PR is enqueued for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mathu-lmn @Nobelium-cfx @prikolium-cfx