tweak(core/sbag): delete state bags that get passed as nil #2717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Delete state bags that have their value gets set to nil.
This will still send the value getting set to
nil
/null
for the client so it will still hitADD_STATE_BAG_CHANGE_HANDLER
and be able to clean up previous state, but it wont be called again on scope enter/leave so it wont lead to unexpected/undesired behavior.Getting values default to
nil
/null
so this shouldn't break compatibility withGET_STATE_BAG_VALUE
.How is this PR achieving the goal
Check for
0xc0
and if the first byte is it, remove it from the state bag mapThis PR applies to the following area(s)
Server
Successfully tested on
Game builds: b3095
Platforms: Windows
Checklist
Fixes issues