-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(onesync/natives): add GetVehicleHornType #2697
Conversation
Should be good @AvarianKnight, thanks |
Can you update your commit messages? Otherwise we can do that as well. |
Should be good |
Thanks 👍 |
the master branch merge was not required, because there was no conflict. Now you need to get that commit await. |
Should be good but looks like the CI didn't succeed to Validate my PR |
The ci isn't happy, because you didnt excluded redm from the code that only works with fivem.
around the native handler. and add
the the native declaration. |
Looking at ServerGame_Scripting only cross native are using the #idef STATE_FIVE |
* Implement the server side native GET_VEHICLE_HORN_TYPE by reading the HornTypeHash bit in the CVehicleAppearance datanode. Co-Authored-By: Dillon Skaggs <[email protected]>
Looks good now 👍 |
Goal of this PR
Adding a server side getter to the client side native
START_VEHICLE_HORN
How is this PR achieving the goal
by reading the HornTypeHash bit in the CVehicleAppearance data node.
This PR applies to the following area(s)
FXServer/FiveM
Successfully tested on
Game builds: 3095
Platforms: Window
Was tested by using StartVehicleHorn client side, then getting the hornType value server side.
To test it, use this snippet, use the setHorn command, then the hornType command
Checklist