Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): Add fwPortalSceneGraphNode pool to gameconfig #2695

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

ook3D
Copy link
Contributor

@ook3D ook3D commented Aug 5, 2024

Currently by default, fwPortalSceneGraphNode is set to 400, servers with many interiors and in turn lots of portals, this can cause a game crash. its possible to simply add this pool to the config to increase it.

currently it says "Unknown Pool full - 400", which makes sense because fwPortalSceneGraphNode is missing from the config therefore its unknown.

Goal of this PR

Adding the pool to the gameconfig and increasing its value to prevent game crashes with many interiors loaded

...

How is this PR achieving the goal

making the pool accessable to the gameconfig.
...

This PR applies to the following area(s)

FiveM
...

Successfully tested on

Game builds: ..

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Currently by default, fwPortalSceneGraphNode is set to 400, servers with many interiors and in turn lots of portals, this can cause a game crash. its possible to simply add this pool to the config to increase it.

currently it says "Unknown Pool full - 400", which makes sense because fwPortalSceneGraphNode is missing from the config therefore its unknown.
@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Aug 5, 2024
@FabianTerhorst FabianTerhorst self-assigned this Aug 18, 2024
@FabianTerhorst FabianTerhorst removed the triage Needs a preliminary assessment to determine the urgency and required action label Aug 18, 2024
Copy link
Contributor

@FabianTerhorst FabianTerhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍

@FabianTerhorst FabianTerhorst added the ready-to-merge This PR is enqueued for merging label Aug 18, 2024
@prikolium-cfx prikolium-cfx merged commit c104813 into citizenfx:master Aug 20, 2024
6 checks passed
@prikolium-cfx
Copy link
Contributor

prikolium-cfx commented Aug 21, 2024

As I can see it doesn't work, because IPL related items allocated from another precalculated Heap. If you still wish to fix it you better take a look on fwSceneGraph::InitPools method, then I hope you will understand what you need to do.

@ook3D
Copy link
Contributor Author

ook3D commented Aug 22, 2024

As I can see it doesn't work, because IPL related items allocated from another precalculated Heap. If you still wish to fix it you better take a look on fwSceneGraph::InitPools method, then I hope you will understand what you need to do.

Hmm interesting, I'll take a look, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants