fix(natives/rpc): Keep code fencing in doc summary #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removing leading and trailing backticks from the native summary section breaks formatting if the summary only contains formatted code. * Keep RPC native summary in sync with client native summary.
github-actions
bot
added
the
triage
prikolium-cfx
approved these changes
Jul 23, 2024
prikolium-cfx
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Removing leading and trailing backticks from the native summary section breaks formatting if the summary only contains formatted code.
How is this PR achieving the goal
Removal of the regex pattern matching for leading and trailing backticks in the doc string parse function when native md is being generated.
See issue citizenfx/natives#1124 for a showcase of the mismatch between client and server native docs.
This PR applies to the following area(s)
Natives
Successfully tested on
Game builds: Not applicable
Platforms: Windows
Checklist
Fixes issues
fixes citizenfx/natives#1124