Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/cfx-ui): updated dependencies #2480

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix(ext/cfx-ui): updated dependencies #2480

merged 1 commit into from
Apr 26, 2024

Conversation

olegmakushev
Copy link
Contributor

@olegmakushev olegmakushev commented Apr 23, 2024 •
edited
Loading

Goal of this PR

Update dependencies to avoid vulnerabilities.

How is this PR achieving the goal

The packages were audited for vulnerabilities. All packages have been updated, except one.

Moderate vulnerabilitie found in tar dependancy of pdfjs-dist package. I tried to update it to a new version but it have API changes that requeres more atantion and I think it will be better to do in a seporate PR.

image

Two packages were removed due to lack of use: imagemin-gifsicle and img-optimize-loader.

This PR applies to the following area(s)

FiveM, RedM

Successfully tested on

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Apr 23, 2024
@olegmakushev olegmakushev changed the title Fix/cfx dependencies fix(ext/cfx-ui): updated dependencies Apr 23, 2024
@github-actions github-actions bot added RedM Issues/PRs related to RedM triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Apr 23, 2024
@nihonium-cfx nihonium-cfx added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action RedM Issues/PRs related to RedM labels Apr 23, 2024
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Apr 23, 2024
@nihonium-cfx nihonium-cfx removed the ready-to-merge This PR is enqueued for merging label Apr 23, 2024
@github-actions github-actions bot added RedM Issues/PRs related to RedM triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Apr 23, 2024
@nihonium-cfx nihonium-cfx added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action RedM Issues/PRs related to RedM labels Apr 23, 2024
@thorium-cfx thorium-cfx merged commit e44dc26 into citizenfx:master Apr 26, 2024
9 checks passed
@thorium-cfx
Copy link
Contributor

I had to revert the changes in this PR due to time constraints, it produced the below build errors. Can you see if you can repro these and make another PR to address them? Thanks

Building UI
yarn install v1.22.5
[1/4] Resolving packages...
[2/4] Fetching packages...
info @swc/[email protected]: The platform "win32" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/[email protected]: The CPU architecture "x64" is incompatible with this module.
info @swc/[email protected]: The platform "win32" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/[email protected]: The CPU architecture "x64" is incompatible with this module.
info @swc/[email protected]: The platform "win32" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/[email protected]: The CPU architecture "x64" is incompatible with this module.
info @swc/[email protected]: The platform "win32" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/[email protected]: The platform "win32" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/[email protected]: The platform "win32" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/[email protected]: The CPU architecture "x64" is incompatible with this module.
info @swc/[email protected]: The platform "win32" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/[email protected]: The CPU architecture "x64" is incompatible with this module.
info @swc/[email protected]: The platform "win32" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/[email protected]: The CPU architecture "x64" is incompatible with this module.
info @swc/[email protected]: The platform "win32" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/[email protected]: The platform "win32" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/[email protected]: The CPU architecture "x64" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/[email protected]: The CPU architecture "x64" is incompatible with this module.
info "@swc/[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info [email protected]: The platform "win32" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
error [email protected]: The engine "node" is incompatible with this module. Expected version "^18.17.0 || ^20.3.0 || >=21.0.0". Got "16.17.1"
warning [email protected]: The engine "libvips" appears to be invalid.
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Failed to build CfxUI
BUILD FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nihonium-cfx nihonium-cfx nihonium-cfx approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olegmakushev @thorium-cfx @nihonium-cfx