Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mono-v2): disallow KeyMap to be used on RedM #2464

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix(mono-v2): disallow KeyMap to be used on RedM #2464

merged 1 commit into from
Apr 26, 2024

Conversation

AvarianKnight
Copy link
Contributor

  • keymap natives are not currently supported by RedM, using these would result in RedM crashing

Goal of this PR

Block the usage of KeyMap on RedM until input mappings are made

How is this PR achieving the goal

Throw a not implemented exception the native is called

This PR applies to the following area(s)

ScRT: C#

Successfully tested on

RedM

Game builds: N/A

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the ScRT: C# Issues/PRs related to either C# scripting runtimes label Apr 16, 2024
@thorium-cfx thorium-cfx self-assigned this Apr 16, 2024
@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Apr 16, 2024
@thorium-cfx thorium-cfx removed the triage Needs a preliminary assessment to determine the urgency and required action label Apr 18, 2024
@AvarianKnight
fix(mono-v2): disallow KeyMap to be used on RedM
4839e2d 
- keymap natives are not currently supported by RedM, using these would result in RedM crashing
@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Apr 18, 2024
@thorium-cfx thorium-cfx added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Apr 18, 2024
@thorium-cfx
Copy link
Contributor

Can be merged together with #2462

@thorium-cfx thorium-cfx merged commit 362711b into citizenfx:master Apr 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorium-cfx thorium-cfx thorium-cfx approved these changes

Assignees

@thorium-cfx thorium-cfx

Labels
ready-to-merge This PR is enqueued for merging ScRT: C# Issues/PRs related to either C# scripting runtimes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AvarianKnight @thorium-cfx