Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mention gameconfig in pool errors in RedM #2446

Merged

Conversation

Disquse
Copy link
Contributor

@Disquse Disquse commented Apr 4, 2024

Goal of this PR

The goal of this PR is to prevent pool error crashes from confusing our players.
See 67d0d60 for more details.

How is this PR achieving the goal

By removing the confusing extra warning.

This PR applies to the following area(s)

RedM

Successfully tested on

Game builds: 1311, 1355, 1436, 1491

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added RedM Issues/PRs related to RedM invalid Requires changes before it's considered valid and can be (re)triaged labels Apr 4, 2024
@gottfriedleibniz gottfriedleibniz added ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Apr 7, 2024
@prikolium-cfx prikolium-cfx merged commit 4fb2546 into citizenfx:master Apr 8, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging RedM Issues/PRs related to RedM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants