fix(scripting-mono-v2): allow scheduling from non-main threads #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes dependency on the Bookmark system, reverting previous changes. * Remains tick-less, though in a different way, it's produces the same results with less work as the Bookmark system. * Start using shared memory between C++ and C#, removing the need for unnecessary interop method calls and extra logic for timing. * Remove leftover `Debug.Writeline`
github-actions
bot
added
ScRT: C#
jakub-cfx
approved these changes
Mar 19, 2024
thorium-cfx
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Enable scheduling tick calls from non-main threads, this is necessary to call back into the runtime (on the main thread) after external libraries used async/await with
Task/Task<T>and we had nothing else scheduled. This didn't work before.How is this PR achieving the goal
By removing its dependency on the Bookmark system (not thread-safe) and replacing it with a simplified version that achieves the same goal, but thread-safe.
This PR applies to the following area(s)
ScRT: C#
Successfully tested on
Server and client
Game builds: 2802
Platforms: Windows, Linux
Checklist
Fixes issues
fixes thorium-cfx/mono_v2_get_started#23