Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(build): Use Boost submodules instead of requiring builders to d… #2399

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

osmium-cfx
Copy link

…ownload+extract a full boost.zip somewhere.

This also lets us use/update specific parts.

No more BOOST_ROOT required!

Goal of this PR

Replace BOOST_ROOT with submodules in the vendor folder.

Remove need to download random .zip and place it in an env var.

Make updating easier

How is this PR achieving the goal

By adding a ton of submodules, and making the necessary changes to use them.

This PR applies to the following area(s)

FiveM/RedM

Successfully tested on

FiveM client, FXServer(Windows), FXServer(Linux)

Game builds: ..
All

Platforms: Windows, Linux

Checklist

  • [ x] Code compiles and has been tested successfully.
  • [ x] Code explains itself well and/or is documented.
  • [ x] My commit message explains what the changes do and what they are for.
  • [ x] No extra compilation warnings are added by these changes.

Fixes issues

fixes #1201

…ownload+extract a full boost.zip somewhere.

This also lets us use/update specific parts.

No more BOOST_ROOT required!
@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Feb 22, 2024
@osmium-cfx osmium-cfx merged commit 0689a08 into citizenfx:master Feb 22, 2024
5 checks passed
@hunga516
Copy link

hunga516 commented Mar 6, 2024

this is a bug, i follow all step and run (Local windows debugger) in VS2019 but no suc as directory "boost/mlp/file"
please rebuild yoursefl in new Windows, please get back BoostRoot

*i have reclone fivem and update submodule

@hunga516
Copy link

hunga516 commented Mar 6, 2024

Ảnh màn hình 2024-03-06 lúc 21 21 19 Ảnh màn hình 2024-03-06 lúc 21 21 33 Ảnh màn hình 2024-03-06 lúc 21 22 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build process: Boost should be made into modular submodules
3 participants