feat(scripting/v8): allow to set the max listeners count #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihonium-cfx
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Hey there, thanks for the PR!
- Commit message needs to refer to
scripting/v8instead ofscripting-v8, see this commit for example: 01a29ec - TypeScript definitions need to be extended to reflect new API added.
Not required, but as a side-quest: would be great to add this functionality for the raw event listener (rawEmitter) as well for feature parity of these.
…d raw event By default any event that is listened more than 10 times will trigger a log error saying that there may be a memory leak. In some cases users may want to listen more than 10 times to a specific event this patch allow to not display a log message in those cases by setting the correct value to the setMaxEventListeners
|
Thanks for the review, i have applied the feedback |
joelwurtz
changed the title
nihonium-cfx
approved these changes
Feb 23, 2024
thorium-cfx
added
the
ScRT: JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
By default any event that is listened more than 10 times will trigger a log error saying that there may be a memory leak.
In some cases users may want to listen more than 10 times to a specific event this patch allow to not display a log message in those cases by setting the correct value to the setMaxEventListeners.
It's not a real problem, but often users will print this error saying it's the cause of a bug (but it's not) and it's misleading.
How is this PR achieving the goal
This PR allow to configure the max listeners count so a developer can set it according to his code behavior.
This PR applies to the following area(s)
FiveM, RedM, Server, ScRT: JS
Successfully tested on
Platforms: Windows, Linux
Checklist
Fixes issues
N/A