Rework camera shake toggle convar in FiveM #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if (g_cameraShakeConvar->GetValue()) | ||
| if (!g_cameraShakeConvar->GetValue()) |
There was a problem hiding this comment.
Feels like g_disableCameraShakeConvar would be a better name to reflect the value of this convar meaning. Since this is a rework - we can improve this as well.
There was a problem hiding this comment.
Even better: how about not calling GetValue on the convar in the hook but instead using the tracking variable support so that there's only a single bool check?
The way how this functionality was implemented before is very fragile and got broken in b3095. The one-way nopping was also breaking the ability to disable this option after disconnecting from a server. So it was decided to rework it a bit.
Disquse
force-pushed
the
fivem/camera-shake-rework
branch
from
1521290
to
606299f
Compare
nihonium-cfx
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
The way how this functionality was implemented before is very fragile and got broken in b3095. The one-way nopping was also breaking the ability to disable this option after disconnecting from a server. So it was decided to rework it a bit.
How is this PR achieving the goal
By reworking the way how this functionality was implemented.
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 1604, 2060, 2189, 2372, 2545, 2612, 2699, 2802, 2944, 3095
Platforms: Windows
Checklist
Fixes issues
Addresses the problem reported in this forum topic (
#3):https://forum.cfx.re/t/a-couple-of-problems-since-the-last-updates/5200554