Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gamer tags crew component in FiveM b3095 #2358

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

Disquse
Copy link
Contributor

@Disquse Disquse commented Jan 22, 2024

Goal of this PR

To make the gamer tags crew component to work on game build 3095.

How is this PR achieving the goal

This is achieved by patching a function that was preventing this functionality from working (some additional unknown "privilege" checks or so).

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: 3095

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Addresses the problem reported in this forum topic:
https://forum.cfx.re/t/gamer-tag-crew-component-does-not-work-on-newest-3095-game-build/5201652

Patch an unknown "privilege" check that is not allowing the crew name to be set.
@nihonium-cfx nihonium-cfx added the ready-to-merge This PR is enqueued for merging label Jan 26, 2024
@nihonium-cfx nihonium-cfx merged commit 10ebcfc into citizenfx:master Jan 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants