Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): give permissions to label PRs #2348

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

thorium-cfx
Copy link
Contributor

Goal of this PR

Enable GitHub PR evaluating workflow to label PRs and continue compile checks

How is this PR achieving the goal

Giving this workflow the issue write permission.

Note: I was unable to test this on my own repos, but research shows it's related to missing the issues write permission (can come from our organization). One would expect this to be fine with pull-requests write permissions.

This PR applies to the following area(s)

GitHub

Successfully tested on

GitHub Runners

Game builds: N/A

Platforms: GitHub Runners

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

I was unable to test this on my own repos, but research shows it's related to missing the `issues` write permission. One would expect this to be fine with `pull-requests` write permissions.
@blattersturm
Copy link
Contributor

ok but when's the 'consice' typo getting fixed

@thorium-cfx
Copy link
Contributor Author

ok but when's the 'consice' typo getting fixed

Haha, I remember this. Fixed after #2349

@thorium-cfx thorium-cfx added the ready-to-merge This PR is enqueued for merging label Jan 18, 2024
@nihonium-cfx nihonium-cfx merged commit b177dbf into citizenfx:master Jan 19, 2024
@thorium-cfx thorium-cfx deleted the fix/github_pr_eval branch April 16, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants