Update CNetGamePlayer accessors to support b3095 in FiveM
#2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was forgotten during the initial work on 3095 support for FiveM. Also did some minor code cleanup.
- Use `GetPlayerInfo` method instead of raw `playerInfo` accessor. - Remove unnecessary float checks + other minor code cleanups.
nihonium-cfx
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fixed a regression introduced in b3095 + minor code tweaks & cleanup.
...
How is this PR achieving the goal
By adding b3095 check in
DECLARE_ACCESSORand replacing raw accessor with a proper method call....
This PR applies to the following area(s)
FiveM, Natives
...
Successfully tested on
Game builds: 3095, 2944, 2372, 2060, 1604
Platforms: Windows
Checklist
Fixes issues
Issue
#2from this report https://forum.cfx.re/t/a-couple-of-problems-since-the-last-updates/5200554