Assorted Steam presence fixes #2324
Conversation
The 'steamname.txt' feature, which allows overriding the product name shown in Steam rich presence, would originally read files as CP_ACP due to a mistaken use of 'wstringstream'/'wifstream'. This means that trying to replicate the existing product name (such as 'FiveM 🐌') would show mojibake instead. Since we can assume people will save files as UTF-8 (even Windows Notepad has this as a default), just not converting this should be safe.
In some cases, needRefresh would be set to true before the existing child process would've picked up on it and exited. Instead, we use a PID match to make sure only the latest process remains.
The Steam work needed utf8::find_invalid(const std::string&), which was introduced in v3.0.0.
With a host name such as "Êîðïîðàöèÿ Ìàéêðîñîôò; Âñå ïðàâà çàùèùåíû", we will try to set a presence name like "test: Êîðïîðàöèÿ Ìàéêðîñîôò; Âñå ïðàâà çàùèùåíû", assuming `steamname.txt` contains "test". Steam, internally, truncates app names to fit in a 64-byte buffer with a null terminator. However, the code which truncates does not ensure the resulting UTF-8 sequence is valid, which might lead to the update being rejected further down the line, which is especially likely with a name consisting solely of multi-byte sequences, like the example name. In this changeset, we circumvent this by truncating the name to 64 bytes ourselves, and subsequently chopping off at the first invalid UTF-8 sequence.
|
Coincidentally, some user posted about an issue similar to this on the forums: https://forum.cfx.re/t/steam-rich-presence-doesnt-work-specifically-on-my-server/5199043 |
|
An additional thought as a result of the topic above applies regarding whether presence - both Steam and Discord - should try to show the project name instead of the raw/legacy hostname, where available. The user's host name was |
nihonium-cfx
added
the
needs manual verification
|
What's this 'needs manual verification' state? I've looked for process details (as said in the October 2023 Community Pulse, I've also not seen this on any previous PR, but I assume it's 'someone will have to review this, but not me' - why not assign a reviewer, then? |
|
It was created to mark PRs that'd need to be manually verified (builds, runs, etc.) by the team and keep track of such PRs. In this case, it is to verify linux build is fine. |
nihonium-cfx
removed
the
needs manual verification
This contains a fix for my test server's non-ASCII host name being broken in Steam presence, and some assorted fixes for issues caught along the way (
steamname.txtreturning mojibake, and leftover SteamChild processes lingering).These changes may not be as meaningful if/when FiveM and RedM are assigned an actual AppID and can use the native rich presence functionality, but for the time being they solve stuff being broken randomly.
Goal of this PR
Fix some issues that showed up regarding Steam presence.
(.. also, the 'consice' typo is still there in the template)
How is this PR achieving the goal
See commit messages for details.
This PR applies to the following area(s)
Client (both FiveM and RedM),
steamcomponent. Also updates a vendor library, this wasn't tested on the Linux build as I do not have a Linux system available at this time - this should however work.Successfully tested on
Game builds: FiveM
Checklist