tweak(data/five): increase audio occlusion related pool sizes #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OcclusionPathNode currently allocates 82 KB, new size would be 312 KB OcclusionPortalInfo currently allocates 42 KB, new size would be 960 KB OcclusionPortalEntity currently allocates 8 KB, new size would be 93 KB So this would increase usage by 1366 KB, which is a reasonable increase for gained possibilities. When linking multiple large interiors together, the amount of path nodes, portal infos and portal entities grows exponentially per interior linked. Co-authored-by: z3t4s <[email protected]> Co-authored-by: okqut <[email protected]>
Disquse
approved these changes
Dec 7, 2023
|
Merged in 80f9e4a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
When linking multiple large interiors together, the amount of path nodes, portal infos and portal entities grows exponentially per interior linked. To allow for this, we need to increase the pool size.
How is this PR achieving the goal
By increasing the following pools;
OcclusionPathNode currently allocates 82 KB, new size would be 312 KB
OcclusionPortalInfo currently allocates 42 KB, new size would be 960 KB
OcclusionPortalEntity currently allocates 8 KB, new size would be 93 KB
So this would increase usage by 1366 KB, which is a reasonable increase for gained possibilities.
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 2372, 2802
Platforms: Windows
Checklist