Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics natives fixes and improvements for RedM #2268

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

Disquse
Copy link
Contributor

@Disquse Disquse commented Nov 7, 2023

  • Reworked draw origin system so now it uses proper structs, making the code to be way more readable.
  • Reworked ScriptIM drawing so now it uses in-game system directly.
  • This (hopefully) fixes flickering when using DRAW_(BOX|POLY|LINE) natives.
  • Vertex ordering in DRAW_POLY is different now (like in GTA5).
  • Added support for DRAW_BOX and SET_BACKFACECULLING (works as in GTA5).

image

Copy link
Contributor

@thorium-cfx thorium-cfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 little thingy, other than that logic seems good

- Reworked draw origin system so now it uses proper structs, making the code to be way more readable.
- Reworked ScriptIM drawing so now it uses in-game system directly.
- This (hopefully) fixes flickering when using `DRAW_(BOX|POLY|LINE)` natives.
- Vertex ordering in `DRAW_POLY` is different now (like in GTA5).
- Added support for `DRAW_BOX` and `SET_BACKFACECULLING` (works as in GTA5).
@Disquse Disquse added ready-to-merge This PR is enqueued for merging RedM Issues/PRs related to RedM labels Jan 11, 2024
@nihonium-cfx nihonium-cfx merged commit 2212495 into citizenfx:master Jan 19, 2024
@Disquse Disquse mentioned this pull request Jan 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging RedM Issues/PRs related to RedM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants