Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extra-natives/five): LOAD_ROPE_DATA_FROM_PATH #2205

Closed
wants to merge 2 commits into from
Closed

feat(extra-natives/five): LOAD_ROPE_DATA_FROM_PATH #2205

wants to merge 2 commits into from

Conversation

packfile
Copy link
Contributor

Adds a way to load a custom rope data file, useful for modifying/creating new ropes with additional textures, radii and colours as seen in https://i.imgur.com/1EpFIyP.png
Additionally fixes the game crashing if calling ADD_ROPE with an invalid index (8 onwards with default rope data loaded)

Copy link
Contributor

@Disquse Disquse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, played around these changes, work as expected, tested on all available game builds

@thorium-cfx
Copy link
Contributor

What would be reasons to add this? And why wouldn't we just load this prior to gameplay?

@thorium-cfx thorium-cfx added the triage Needs a preliminary assessment to determine the urgency and required action label Nov 23, 2023
@packfile
Copy link
Contributor Author

packfile commented Nov 23, 2023

What would be reasons to add this?

Currently there is not a trivial way (afaik) to replace the default ropedata file as the path is hardcoded, this adds a way to load one. A use case was brought up where someone wanted to make a rope that was thicker and used a custom texture

And why wouldn't we just load this prior to gameplay?

Did it this way to match a similar native that was implemented

@blattersturm
Copy link
Contributor

And why wouldn't we just load this prior to gameplay?

Resources can be started and stopped during gameplay as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants