feat(net): attribute proper packet names for timeout #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but while ur at it, maybe add the hash as a // comment so we can ctrl-f for it sometime later |
AvarianKnight
force-pushed
the
feat/format-packets
branch
from
5d4b521
to
c269245
Compare
blattersturm
suggested changes
Oct 19, 2023
AvarianKnight
force-pushed
the
feat/format-packets
branch
from
c269245
to
b11e635
Compare
|
Applied the requested changes, also replaced g_knownPackets in NetDebug.cpp to use g_knownPackets from KnownPackets.h |
thorium-cfx
suggested changes
Nov 3, 2023
thorium-cfx
suggested changes
Nov 3, 2023
AvarianKnight
force-pushed
the
feat/format-packets
branch
from
b11e635
to
7800517
Compare
if a player times out instead of getting the packet hash they will get the packet name
AvarianKnight
force-pushed
the
feat/format-packets
branch
from
7800517
to
eff3edb
Compare
4 tasks
|
This pretty simple PR has been sitting for 9 months, so I'm going to assume the changes are unwanted. |
FabianTerhorst
approved these changes
Jun 11, 2024
github-actions
bot
added
the
triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so if a player times out, instead of getting packet hash as hex they'll get the actual packet name