tweak(onesync): Change f164 to weaponHash for explosionEvent #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should keep the old parameter for backwards compatibility but add new ones with the proper names, you can see an old pr for reference |
blattersturm
suggested changes
Jan 3, 2023
| @@ -4356,7 +4356,7 @@ struct CExplosionEvent | |||
| bool f190; | |||
| bool f191; | |||
|
|
|||
| uint32_t f164; | |||
| uint32_t weaponHash; | |||
There was a problem hiding this comment.
See @AvarianKnight's comment above.
blattersturm
added
the
manual-review
thorium-cfx
added
the
triage
|
Closed as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is wanted for backwards compatibility sake, but does make code a lot more readable.
Had a log of a lot of explosionEvents happening, and for the ones I could find (mostly fire hydrants, vehicles and gas canisters) this value was always
WEAPON_EXPLOSION