Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese prompts for reference free OpenAI-based metrics #87

Merged
merged 9 commits into from
Feb 27, 2024

Conversation

yosukehigashi
Copy link
Contributor

@yosukehigashi yosukehigashi commented Feb 19, 2024

Updates all reference free OpenAI-based metrics to Japanese prompts.

Updating the factual consistency prompt to Japanese is still a TODO - this one was more difficult and all our attempts considerably lowered the performance on the JNLI benchmark.

@yosukehigashi yosukehigashi changed the base branch from main to ja-function-calling February 19, 2024 05:45
Base automatically changed from ja-function-calling to main February 20, 2024 05:24
@yosukehigashi yosukehigashi changed the title Japanese prompts for OpenAI-based metrics Japanese prompts for reference free OpenAI-based metrics Feb 21, 2024
@yosukehigashi yosukehigashi marked this pull request as ready for review February 21, 2024 07:38
@yosukehigashi yosukehigashi requested a review from liwii February 21, 2024 07:38
Copy link
Contributor

@liwii liwii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used it for a few times and they seem working fine.

Left just one nit comment.


def _prompt(gen_output: str) -> str:
return f'''
提出されたテキストのセンチメントを評価してください。データは以下の通りです:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"センチメント" doesn't seem familiar to me even as a katakana-word. Maybe "感情" instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it! updated to 感情

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@yosukehigashi yosukehigashi merged commit 1e7f583 into main Feb 27, 2024
2 checks passed
@yosukehigashi yosukehigashi deleted the ja-prompts branch February 27, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants