German improvements #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @ischender!! Left a few comments about the benchmarking notebook!
| "# annotated scores\n", | ||
| "from langcheck.metrics.de import factual_consistency\n", | ||
| "import os\n", | ||
| "\n", |
There was a problem hiding this comment.
I think we need these lines below, since the model_type is azure_openai
os.environ["AZURE_OPENAI_KEY"] = 'YOUR_AZURE_OPENAI_KEY'
os.environ["OPENAI_API_VERSION"] = 'YOUR_OPENAI_API_VERSION'
os.environ["AZURE_OPENAI_ENDPOINT"] = 'YOUR_AZURE_OPENAI_ENDPOINT'
There was a problem hiding this comment.
oh yes, I guess I had removed it while tinkering... re-added
Co-authored-by: Yosuke Higashi <[email protected]>
Co-authored-by: Yosuke Higashi <[email protected]>
yosukehigashi
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
LGTM! Let's merge this one first since #82 also changes the benchmarking notebook
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny changes:
a) adding DE to the main README
b) adding a notebook for factual consistency (it was still work in progress at the time of last PR)