Skip to content

Commit

Permalink
Update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kennysong committed Feb 19, 2024
1 parent 6dedc43 commit 92139aa
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions .github/workflows/pip_install_matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
os: macos-14
- python-version: "3.9"
os: macos-14
# TODO: We need to manually install MeCab on Windows to install
# TODO: Figure out how to install MeCab on Windows to install
# LangCheck on Python 3.12 since there are no wheels for `fugashi`
- python-version: "3.12"
os: windows-latest
Expand All @@ -45,12 +45,16 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

# We need to manually install MeCab on Ubuntu to install LangCheck on
# Python 3.12 since there are no wheels for `fugashi`
- name: Install MeCab on Ubuntu (if necessary)
if: ${{ matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12' }}
run: |
sudo apt-get update
sudo apt-get install -y mecab libmecab-dev mecab-ipadic-utf8
# We need to manually install MeCab on macOS to install LangCheck on
# Python 3.12 since there are no wheels for `fugashi`
- name: Install MeCab on macOS (if necessary)
if: ${{ matrix.os == 'macos-14' && matrix.python-version == '3.12' }}
run: |
Expand All @@ -64,4 +68,8 @@ jobs:
- name: Install Core LangCheck with Optional Dependencies
run: |
pip install .[optional]
pip install .[optional]
- name: Import LangCheck
run: |
python -c "import langcheck"

0 comments on commit 92139aa

Please sign in to comment.