-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.7.4 fixes for EL9 #91
Open
danfruehauf
wants to merge
5
commits into
cisco:master
Choose a base branch
from
danfruehauf:el9_fixes_2_7_4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el9 dropped support for it, as the mainline kernel also did, see: https://lore.kernel.org/lkml/[email protected]/ And git commit message saying: ``` pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. ```
This was referenced May 24, 2024
danfruehauf
force-pushed
the
el9_fixes_2_7_4
branch
from
May 24, 2024 00:43
015e328
to
25da2e9
Compare
build failed on Rocky 8.10 make -C modules/exanic
make[1]: Entering directory '/root/exanic-software/modules/exanic'
make -C /lib/modules/`uname -r`/build M=$PWD modules
make[2]: Entering directory '/usr/src/kernels/4.18.0-553.el8_10.x86_64'
Building modules, stage 2.
MODPOST 1 modules
make[2]: Leaving directory '/usr/src/kernels/4.18.0-553.el8_10.x86_64'
make[1]: Leaving directory '/root/exanic-software/modules/exanic'
make -C modules/exasock
make[1]: Entering directory '/root/exanic-software/modules/exasock'
make -C /lib/modules/`uname -r`/build M=$PWD KBUILD_EXTRA_SYMBOLS=/root/exanic-software/modules/exasock/../exanic/Module.symvers modules
make[2]: Entering directory '/usr/src/kernels/4.18.0-553.el8_10.x86_64'
CC [M] /root/exanic-software/modules/exasock/exasock-bonding-sysfs.o
In file included from ./include/linux/kobject.h:20,
from ./include/linux/device.h:17,
from ./include/linux/dma-mapping.h:7,
from ./include/linux/skbuff.h:34,
from ./include/linux/if_ether.h:23,
from ./include/uapi/linux/if_bonding.h:49,
from ./include/net/bonding.h:20,
from /root/exanic-software/modules/exasock/exasock-bonding-sysfs.c:13:
/root/exanic-software/modules/exasock/exasock-bonding-sysfs.c:143:22: error: initialization of ‘ssize_t (*)(struct class *, struct class_attribute *, char *)’ {aka ‘long int (*)(struct class *, struct class_attribute *, char *)’} from incompatible pointer type ‘ssize_t (*)(const struct class *, const struct class_attribute *, char *)’ {aka ‘long int (*)(const struct class *, const struct class_attribute *, char *)’} [-Werror=incompatible-pointer-types]
143 | static CLASS_ATTR_RW(exabond_masters);
| ^~~~~~~~~~~~~~~
./include/linux/sysfs.h:104:10: note: in definition of macro ‘__ATTR’
104 | .show = _show, \
| ^~~~~
./include/linux/device.h:746:46: note: in expansion of macro ‘__ATTR_RW’
746 | struct class_attribute class_attr_##_name = __ATTR_RW(_name)
| ^~~~~~~~~
/root/exanic-software/modules/exasock/exasock-bonding-sysfs.c:143:8: note: in expansion of macro ‘CLASS_ATTR_RW’
143 | static CLASS_ATTR_RW(exabond_masters);
| ^~~~~~~~~~~~~
/root/exanic-software/modules/exasock/exasock-bonding-sysfs.c:143:22: note: (near initialization for ‘class_attr_exabond_masters.show’)
143 | static CLASS_ATTR_RW(exabond_masters);
| ^~~~~~~~~~~~~~~
./include/linux/sysfs.h:104:10: note: in definition of macro ‘__ATTR’
104 | .show = _show, \
| ^~~~~
./include/linux/device.h:746:46: note: in expansion of macro ‘__ATTR_RW’
746 | struct class_attribute class_attr_##_name = __ATTR_RW(_name)
| ^~~~~~~~~
/root/exanic-software/modules/exasock/exasock-bonding-sysfs.c:143:8: note: in expansion of macro ‘CLASS_ATTR_RW’
143 | static CLASS_ATTR_RW(exabond_masters);
| ^~~~~~~~~~~~~
/root/exanic-software/modules/exasock/exasock-bonding-sysfs.c:143:22: error: initialization of ‘ssize_t (*)(struct class *, struct class_attribute *, const char *, size_t)’ {aka ‘long int (*)(struct class *, struct class_attribute *, const char *, long unsigned int)’} from incompatible pointer type ‘ssize_t (*)(const struct class *, const struct class_attribute *, const char *, size_t)’ {aka ‘long int (*)(const struct class *, const struct class_attribute *, const char *, long unsigned int)’} [-Werror=incompatible-pointer-types]
143 | static CLASS_ATTR_RW(exabond_masters);
| ^~~~~~~~~~~~~~~
./include/linux/sysfs.h:105:11: note: in definition of macro ‘__ATTR’
105 | .store = _store, \
| ^~~~~~
./include/linux/device.h:746:46: note: in expansion of macro ‘__ATTR_RW’
746 | struct class_attribute class_attr_##_name = __ATTR_RW(_name)
| ^~~~~~~~~
/root/exanic-software/modules/exasock/exasock-bonding-sysfs.c:143:8: note: in expansion of macro ‘CLASS_ATTR_RW’
143 | static CLASS_ATTR_RW(exabond_masters);
| ^~~~~~~~~~~~~
/root/exanic-software/modules/exasock/exasock-bonding-sysfs.c:143:22: note: (near initialization for ‘class_attr_exabond_masters.store’)
143 | static CLASS_ATTR_RW(exabond_masters);
| ^~~~~~~~~~~~~~~
./include/linux/sysfs.h:105:11: note: in definition of macro ‘__ATTR’
105 | .store = _store, \
| ^~~~~~
./include/linux/device.h:746:46: note: in expansion of macro ‘__ATTR_RW’
746 | struct class_attribute class_attr_##_name = __ATTR_RW(_name)
| ^~~~~~~~~
/root/exanic-software/modules/exasock/exasock-bonding-sysfs.c:143:8: note: in expansion of macro ‘CLASS_ATTR_RW’
143 | static CLASS_ATTR_RW(exabond_masters);
| ^~~~~~~~~~~~~
/root/exanic-software/modules/exasock/exasock-bonding-sysfs.c:464:22: error: expected identifier or ‘(’ before ‘const’
464 | const struct class_attribute *cattr,
| ^~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:318: /root/exanic-software/modules/exasock/exasock-bonding-sysfs.o] Error 1
make[2]: *** [Makefile:1619: _module_/root/exanic-software/modules/exasock] Error 2
make[2]: Leaving directory '/usr/src/kernels/4.18.0-553.el8_10.x86_64'
make[1]: *** [Makefile:48: default] Error 2
make[1]: Leaving directory '/root/exanic-software/modules/exasock'
make: *** [Makefile:10: modules] Error 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.