Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux 6.1 fixes #71

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Linux 6.1 fixes #71

wants to merge 3 commits into from

Conversation

georgmu
Copy link

@georgmu georgmu commented Apr 25, 2023

Linux 6.1 has several minor changes which result in compile errors and compile warnings.

The three commits solve these issues. The commit messages contain the details.

pci_set_dma_mask() and pci_set_consistent_dma_mask() were removed with
kernel 5.18.

dma_set_mask_and_coherent() exists since kernel 3.13.
The last parameter (weight) of netif_napi_add() was removed with kernel 6.1
with linux commit b48b89f9c1. The weight of 64 is now the default.
netdev->dev_addr is const now. This fixes compilation warning and an OOPS
with linux 5.17+.
@gs-kamnas
Copy link

gs-kamnas commented Jul 21, 2023

I have encountered this same behavior on RHEL8.8 which backports the changes to netif_napi_add (https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=b48b89f9c189d24eb5e2b4a0ac067da5a24ee86d) and have opened #78 as a result.

However, I might recommend updating your conditional in 5e0c16e to also test for RHEL >=8.8 (in addition to kernel > 6.1) as that would be a more "universal" fix to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants