This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
Use ConvertResult for FTs #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radkrawczyk
approved these changes
Jun 28, 2024
| supported_template_types: Tuple = tuple() | ||
|
|
||
| def __init__(self) -> None: | ||
| if not self.supported_template_types: |
There was a problem hiding this comment.
what do you think about returning the "unsupported" conversion_result instead of raising the exception?
There was a problem hiding this comment.
Sure good idea 👍
| raise ValueError("supported_template_types must be defined in the subclass") | ||
| self._convert_result = ConvertResult[AnyParcel]() | ||
|
|
||
| def create_parcel(self, name: str, description: str, template_values: dict) -> Optional[AnyParcel]: |
There was a problem hiding this comment.
ABC, @AbstractMethod?
There was a problem hiding this comment.
Changed FTConverter to abstract class and used abstractmethod
sbasan
approved these changes
Jul 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary:
Description of changes:
[Add more in depth analysis of what changed, provide logs, examples of usage]
Checklist: