Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type and language labels to k8s deployment templates #148

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Feb 6, 2025

Description

This fixes #147 by introducing 2 additional labels to the deployments, one for the component and one for the type

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@svrnm svrnm requested a review from a team as a code owner February 6, 2025 12:28
Copy link

github-actions bot commented Feb 6, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

@noMoreCLI noMoreCLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm
shouldn't we define defaults for loader and database type too?
Or is there a specific reason why not to define a default?

@svrnm
Copy link
Member Author

svrnm commented Feb 7, 2025

@svrnm shouldn't we define defaults for loader and database type too? Or is there a specific reason why not to define a default?

I copied that from a few lines below where you defined a default for the service but not for the other ones, I think that needs to be consistent eventually

@svrnm svrnm merged commit 9012aa1 into main Feb 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add language annotation to k8s deployment files
2 participants