Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add language annotation to k8s deployment files #147

Closed
2 tasks done
svrnm opened this issue Feb 6, 2025 · 0 comments · Fixed by #148
Closed
2 tasks done

[Feature]: Add language annotation to k8s deployment files #147

svrnm opened this issue Feb 6, 2025 · 0 comments · Fixed by #148
Labels
enhancement New feature or request triage This issue or pull request requires triaging

Comments

@svrnm
Copy link
Member

svrnm commented Feb 6, 2025

Problem Statement

When I run app simulator with the k8s generator and deploy my services to k8s, I can not easily identify the language used for a service using kubectl or other kubernetes tooling. This would especially come handy if I want to apply automatic instrumentation based on annotations with the otel operator

Proposed Solution

I suggest that we add a few more labels to the services, i.e.

  • app.kubernetes.io/component (from the recommended labels) with value database, service, loader, etc, such that my instrumentation only aims at services
  • app-simulator.io/type with the type attribute from our config java

Later on we can decide to add more attributes into labels (or annotations), but I think those 2 are important to be added to enable some more features.

Alternatives Considered

No response

Additional Context

No response

Checklist

@svrnm svrnm added enhancement New feature or request triage This issue or pull request requires triaging labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage This issue or pull request requires triaging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant