-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated RFC 4408 citation to RFC 7208 and added link in README #137
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @chrislandis!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we change the documentation has the code been verified to conform to 7208? RFC 4408 was experimental and there are likely to have been changes in the proposed standard (RFC 7208). If this was originally written against 4408 then before we claim it checks records in accordance with 7208 we should make sure that is the case.
Great point, @mcdonnnj! In my look at the code (which was not a thorough verification), I did not happen to see any way in which There are various courses of action that we could take from here in support of this verification.
|
Ensure the use of the same version of `actions/setup-python`
🗣 Description
This pull request updates the README's RFC 4408 citation to RFC 7208 and adds a link thereto.
💭 Motivation and context
We do not want
trustymail
documentation (or code) to cite superseded references. RFC 7208 superseded RFC 4408. Resolves #136.🧪 Testing
After making the change to the README, I pushed the change to my forked repo and could proof-read the text and test the link from there.
✅ Pre-approval checklist