Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sample report for v0.4 #592

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Update sample report for v0.4 #592

merged 2 commits into from
Feb 11, 2025

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Feb 10, 2025

🗣 Description

Update the sample report packaged with ScubaGoggles.

💭 Motivation and context

Closes #590.

🧪 Testing

N/A

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@adhilto adhilto added documentation This issue or pull request improves or adds to documentation High labels Feb 10, 2025
@adhilto adhilto added this to the Driftwood milestone Feb 10, 2025
@adhilto adhilto self-assigned this Feb 10, 2025
@adhilto adhilto linked an issue Feb 10, 2025 that may be closed by this pull request
Update Sample Reports for v0.4 #590
Closed
snarve
snarve approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@snarve snarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR. The orgname is auto generated by the script.

@snarve snarve merged commit f5e6d52 into main Feb 11, 2025
12 checks passed
@snarve snarve deleted the 590-update-sample-reports-for-v04 branch February 11, 2025 00:05
buidav pushed a commit that referenced this pull request Feb 13, 2025
@adhilto @buidav
Update sample report for v0.4 (#592)
1126c84 
* Update sample report

* Minor typo fix
buidav pushed a commit that referenced this pull request Feb 13, 2025
@adhilto @buidav
Update sample report for v0.4 (#592)
842dcf9 
* Update sample report

* Minor typo fix
buidav pushed a commit that referenced this pull request Feb 13, 2025
@adhilto @buidav
Update sample report for v0.4 (#592)
7b558c1 
* Update sample report

* Minor typo fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarve snarve snarve approved these changes

@mitchelbaker-cisa mitchelbaker-cisa mitchelbaker-cisa approved these changes

Assignees

@adhilto adhilto

Labels
documentation This issue or pull request improves or adds to documentation High
Projects
None yet
Milestone
Driftwood
Development

Successfully merging this pull request may close these issues.

Update Sample Reports for v0.4
3 participants
@adhilto @snarve @mitchelbaker-cisa