Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Case of No Sub-Orgunits and No Groups in Tenant #577

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rlxdev
Copy link
Collaborator

@rlxdev rlxdev commented Jan 23, 2025

🗣 Description

The code changes made for this issue handle the case where the tenant has only the top orgunit - no sub-orgunits and no groups. It was discovered and reported by a user.

Closes #573

🧪 Testing

Tested internally via debugger, simulating that only the top-level orgunit existed without any sub-orgunits and groups.
The user who reported this issue also tested the proposed change and has confirmed that the changes resolve the issue.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@rlxdev rlxdev self-assigned this Jan 23, 2025
@rlxdev rlxdev added the bug This issue or pull request addresses broken functionality label Jan 23, 2025
Base automatically changed from 519-policy-api-updates to main February 5, 2025 19:43
@rlxdev rlxdev force-pushed the 573-no-groups-suborgunits branch from 7d60224 to c6aace9 Compare February 5, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant