Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UUID feature #575

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add UUID feature #575

wants to merge 1 commit into from

Conversation

rlxdev
Copy link
Collaborator

@rlxdev rlxdev commented Jan 22, 2025 •
edited
Loading

🗣 Description

Add UUID on the report page

Generate UUID

Closes #439

🧪 Testing

Generate a ScubaGoggle report and validate if the uuid field is displayed.

Test the changes on Mac environment.

Should be minimal

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@rlxdev rlxdev added this to the Driftwood milestone Jan 22, 2025
@prodjom prodjom assigned prodjom, rlxdev and aormu and unassigned prodjom Jan 29, 2025
Base automatically changed from 519-policy-api-updates to main February 5, 2025 19:43
@rlxdev rlxdev marked this pull request as ready for review February 5, 2025 20:00
@rlxdev rlxdev added the eel label Feb 5, 2025
@snarve snarve modified the milestones: Driftwood, Eel Feb 11, 2025
@buidav
Copy link
Collaborator

buidav commented Feb 12, 2025

@rlxdev Can you designate reviewers for this PR?

@adhilto adhilto mentioned this pull request Feb 13, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rlxdev rlxdev

@aormu aormu

Labels
eel enhancement
Projects
None yet
Milestone
Eel
Development

Successfully merging this pull request may close these issues.

Add UUID to Output
5 participants
@rlxdev @buidav @aormu @snarve @prodjom