smoke_test: Fix Failure on Windows GitHub Workflow #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rlxdev
force-pushed
the
529-fix-smoke-test
branch
from
3d799fe to
dd1d14e
Compare
rlxdev
force-pushed
the
529-fix-smoke-test
branch
from
dd1d14e to
40f8602
Compare
buidav
reviewed
Jan 26, 2025
There was a problem hiding this comment.
Ran workflow manually against windows/macos with python versions 3.10, 3.11, 3.12 and latest OPA. All passed, but had to rerun the windows 3.12 test due to Google Policy API rate limits (something to keep in mind if testing multiple versions).
|
The smoke test was failing on Windows and Alden temporarily limited the workflow to run on macOS. With the changes in this PR, the smoke test successfully runs on the Windows workflow. I’m suggesting that this PR be approved as it accomplishes the goal of fixing the issue. |
mitchelbaker-cisa
approved these changes
Jan 29, 2025
buidav
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Fixed the smoke test for the Windows workflow by correcting the use of the Python virtual environments for both OS flows. GitHub uses 2 drives in its VM/container when running a workflow on Windows, and it looks like OPA isn't handling it correctly when the current working directory is on one drive and is being passed input files on another drive. Regardless, we should be using the Python virtual environment correctly, and this fix takes care of the OPA issue as well (because OPA is run with the current working directory on the same drive as the input data).
The default OPA version used in the smoke test has been updated to v1.0.0. We really should be running the latest version of OPA for this test so we can catch any OPA issues before ScubaGoggles users encounter them.
Closes #529
🧪 Testing
Ran the smoke test workflow with both macOS and Windows runners and the tests complete successfully.
✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and mergebutton.✅ Post-merge Checklist