Add a badge for the functional tests #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-garriss
added
the
enhancement
mitchelbaker-cisa
requested changes
Sep 17, 2024
schrolla
force-pushed
the
883-add-functional-test-badge
branch
from
4ea8e1d
to
8d3938d
Compare
james-garriss
force-pushed
the
883-add-functional-test-badge
branch
from
8d3938d
to
0686cdd
Compare
mitchelbaker-cisa
approved these changes
Sep 20, 2024
|
@nanda-katikaneni ready to merge |
james-garriss
added a commit
that referenced
this pull request
Oct 14, 2024
* add badge * fix badge URL * fix badge url * fix pipeline badge * Fix typo in pipeline badge markdown * Update workflow names for the badges * Update badge names * Undo name change * redo name changes * use reference links create workflow fix lint set cancel to false add needs add more jobs add composite action fix typos add hello name add create pfx fix tabbing in create PFX push on action updates move env to main workflow add import pfx fix typo in actions add shell to import pfx add get thumbprint test pwsh correct action names fix env variable for import fix step names try real import action use pw w import fix indents in thumbprint add install selenium add setup sg combine some steps add missing env test product add missing apos mod on push add missing id try id on action fix on push write output move id test tp remove pipe to null cat get env comment out extra steps look at files look at more files look at x more write host put tp back move id id on both test input try env 123 fix 123 typo use output test id on step cleanup output setup params test the product test 2 products fix product alias variable switch to teams switch to prod params, add email fix indent use email action not composite fix comment Test Defender for email notify add schedule back fail on push use dev params updated email test teams pub to private repo restore from cache add with path repo cd repo more repo add repo to import mod re run change order add quotes change module name create dir first remove create dir use full key delete caches set tokn install gh comment reorder set repo Comment better add write privs change restore order add quotes to dirs cleanup the clear cache use double quotes for program files test cache ignore program files list modules Change SG dir add program files back fix typo align cache restore fix path import selenium install selenium hide ast and azure delete unused steps fix lint remove 2 steps clear cache fix needs name clear cache remove comment delete 3 caches remove commas fix keys fix keys debug fix keys fix keys remove newlines fix keys use bash array fix var typo fix variable test w 3 products add email rewrite cache comment out exch fix needs fix cache key improve cache fix email typo add break to drop out of loop move teams to separate workflow set unique name add push path comment out all but checkout comment out clear cache comment out everything slim and trim add permissions fix permissions restore publish fix permissions add needs remove workflow call fix needs back to workflow pass secrets to workflow call add secrets to action use with for passing secrets add missing $ fix lint use env from reusable workflow to composite test var fix value use secrets remove echo use env wip wip wip wip fix thumb complete test fix inputs move thumb to env remove extra inputs get thumb from env fix colon env for thumb new step for thumb use with use output fix needs fix needs input the thumb fix thumb fix thumb fix outputs read all fix perms fix perms put publish into reusable workflow fix permissions add push put cache in own workflow set cache permissions add push cache write all constrain delete cache use job id test tenant 2 add sharepoint add exchange add defender fix cache dependencies added all nightly tests - ka-boom! fix lint pass github.job add new inputs fix needs hardcode alias hardcode alias hard card alias add entra fix cache fix bugs in inputs fix issues in other products Fix Checkov Comment out debugging. remove debug, fix checkov fix pipelines runs for the new dirs fix merge conflicts fix checkov suppress checkov error for cache fix lint clean up everything for release to prod Set Defender back to dev params Set Defender back to prod always run variants
james-garriss
added a commit
that referenced
this pull request
Oct 14, 2024
* add badge * fix badge URL * fix badge url * fix pipeline badge * Fix typo in pipeline badge markdown * Update workflow names for the badges * Update badge names * Undo name change * redo name changes * use reference links create workflow fix lint set cancel to false add needs add more jobs add composite action fix typos add hello name add create pfx fix tabbing in create PFX push on action updates move env to main workflow add import pfx fix typo in actions add shell to import pfx add get thumbprint test pwsh correct action names fix env variable for import fix step names try real import action use pw w import fix indents in thumbprint add install selenium add setup sg combine some steps add missing env test product add missing apos mod on push add missing id try id on action fix on push write output move id test tp remove pipe to null cat get env comment out extra steps look at files look at more files look at x more write host put tp back move id id on both test input try env 123 fix 123 typo use output test id on step cleanup output setup params test the product test 2 products fix product alias variable switch to teams switch to prod params, add email fix indent use email action not composite fix comment Test Defender for email notify add schedule back fail on push use dev params updated email test teams pub to private repo restore from cache add with path repo cd repo more repo add repo to import mod re run change order add quotes change module name create dir first remove create dir use full key delete caches set tokn install gh comment reorder set repo Comment better add write privs change restore order add quotes to dirs cleanup the clear cache use double quotes for program files test cache ignore program files list modules Change SG dir add program files back fix typo align cache restore fix path import selenium install selenium hide ast and azure delete unused steps fix lint remove 2 steps clear cache fix needs name clear cache remove comment delete 3 caches remove commas fix keys fix keys debug fix keys fix keys remove newlines fix keys use bash array fix var typo fix variable test w 3 products add email rewrite cache comment out exch fix needs fix cache key improve cache fix email typo add break to drop out of loop move teams to separate workflow set unique name add push path comment out all but checkout comment out clear cache comment out everything slim and trim add permissions fix permissions restore publish fix permissions add needs remove workflow call fix needs back to workflow pass secrets to workflow call add secrets to action use with for passing secrets add missing $ fix lint use env from reusable workflow to composite test var fix value use secrets remove echo use env wip wip wip wip fix thumb complete test fix inputs move thumb to env remove extra inputs get thumb from env fix colon env for thumb new step for thumb use with use output fix needs fix needs input the thumb fix thumb fix thumb fix outputs read all fix perms fix perms put publish into reusable workflow fix permissions add push put cache in own workflow set cache permissions add push cache write all constrain delete cache use job id test tenant 2 add sharepoint add exchange add defender fix cache dependencies added all nightly tests - ka-boom! fix lint pass github.job add new inputs fix needs hardcode alias hardcode alias hard card alias add entra fix cache fix bugs in inputs fix issues in other products Fix Checkov Comment out debugging. remove debug, fix checkov fix pipelines runs for the new dirs fix merge conflicts fix checkov suppress checkov error for cache fix lint clean up everything for release to prod Set Defender back to dev params Set Defender back to prod always run variants
nanda-katikaneni
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Add a badge for the functional tests (#1319) * add badge * fix badge URL * fix badge url * fix pipeline badge * Fix typo in pipeline badge markdown * Update workflow names for the badges * Update badge names * Undo name change * redo name changes * use reference links create workflow fix lint set cancel to false add needs add more jobs add composite action fix typos add hello name add create pfx fix tabbing in create PFX push on action updates move env to main workflow add import pfx fix typo in actions add shell to import pfx add get thumbprint test pwsh correct action names fix env variable for import fix step names try real import action use pw w import fix indents in thumbprint add install selenium add setup sg combine some steps add missing env test product add missing apos mod on push add missing id try id on action fix on push write output move id test tp remove pipe to null cat get env comment out extra steps look at files look at more files look at x more write host put tp back move id id on both test input try env 123 fix 123 typo use output test id on step cleanup output setup params test the product test 2 products fix product alias variable switch to teams switch to prod params, add email fix indent use email action not composite fix comment Test Defender for email notify add schedule back fail on push use dev params updated email test teams pub to private repo restore from cache add with path repo cd repo more repo add repo to import mod re run change order add quotes change module name create dir first remove create dir use full key delete caches set tokn install gh comment reorder set repo Comment better add write privs change restore order add quotes to dirs cleanup the clear cache use double quotes for program files test cache ignore program files list modules Change SG dir add program files back fix typo align cache restore fix path import selenium install selenium hide ast and azure delete unused steps fix lint remove 2 steps clear cache fix needs name clear cache remove comment delete 3 caches remove commas fix keys fix keys debug fix keys fix keys remove newlines fix keys use bash array fix var typo fix variable test w 3 products add email rewrite cache comment out exch fix needs fix cache key improve cache fix email typo add break to drop out of loop move teams to separate workflow set unique name add push path comment out all but checkout comment out clear cache comment out everything slim and trim add permissions fix permissions restore publish fix permissions add needs remove workflow call fix needs back to workflow pass secrets to workflow call add secrets to action use with for passing secrets add missing $ fix lint use env from reusable workflow to composite test var fix value use secrets remove echo use env wip wip wip wip fix thumb complete test fix inputs move thumb to env remove extra inputs get thumb from env fix colon env for thumb new step for thumb use with use output fix needs fix needs input the thumb fix thumb fix thumb fix outputs read all fix perms fix perms put publish into reusable workflow fix permissions add push put cache in own workflow set cache permissions add push cache write all constrain delete cache use job id test tenant 2 add sharepoint add exchange add defender fix cache dependencies added all nightly tests - ka-boom! fix lint pass github.job add new inputs fix needs hardcode alias hardcode alias hard card alias add entra fix cache fix bugs in inputs fix issues in other products Fix Checkov Comment out debugging. remove debug, fix checkov fix pipelines runs for the new dirs fix merge conflicts fix checkov suppress checkov error for cache fix lint clean up everything for release to prod Set Defender back to dev params Set Defender back to prod always run variants * change job permissions * fix paths * fix cleanup permissions * fix publish permissions * fix all test permissions * set specific cache permissions * clean up permissions * test permissions for cache * fix needs * remove cache * update job name * Removed or for email when pushing code. * remove comments * change email type * simplify * schedule equal empty * Print Values * fix schedule * fix all if conditions * uncomment * Remove debugging * remove comment
mitchelbaker-cisa
pushed a commit
that referenced
this pull request
Nov 6, 2024
* Add a badge for the functional tests (#1319) * add badge * fix badge URL * fix badge url * fix pipeline badge * Fix typo in pipeline badge markdown * Update workflow names for the badges * Update badge names * Undo name change * redo name changes * use reference links create workflow fix lint set cancel to false add needs add more jobs add composite action fix typos add hello name add create pfx fix tabbing in create PFX push on action updates move env to main workflow add import pfx fix typo in actions add shell to import pfx add get thumbprint test pwsh correct action names fix env variable for import fix step names try real import action use pw w import fix indents in thumbprint add install selenium add setup sg combine some steps add missing env test product add missing apos mod on push add missing id try id on action fix on push write output move id test tp remove pipe to null cat get env comment out extra steps look at files look at more files look at x more write host put tp back move id id on both test input try env 123 fix 123 typo use output test id on step cleanup output setup params test the product test 2 products fix product alias variable switch to teams switch to prod params, add email fix indent use email action not composite fix comment Test Defender for email notify add schedule back fail on push use dev params updated email test teams pub to private repo restore from cache add with path repo cd repo more repo add repo to import mod re run change order add quotes change module name create dir first remove create dir use full key delete caches set tokn install gh comment reorder set repo Comment better add write privs change restore order add quotes to dirs cleanup the clear cache use double quotes for program files test cache ignore program files list modules Change SG dir add program files back fix typo align cache restore fix path import selenium install selenium hide ast and azure delete unused steps fix lint remove 2 steps clear cache fix needs name clear cache remove comment delete 3 caches remove commas fix keys fix keys debug fix keys fix keys remove newlines fix keys use bash array fix var typo fix variable test w 3 products add email rewrite cache comment out exch fix needs fix cache key improve cache fix email typo add break to drop out of loop move teams to separate workflow set unique name add push path comment out all but checkout comment out clear cache comment out everything slim and trim add permissions fix permissions restore publish fix permissions add needs remove workflow call fix needs back to workflow pass secrets to workflow call add secrets to action use with for passing secrets add missing $ fix lint use env from reusable workflow to composite test var fix value use secrets remove echo use env wip wip wip wip fix thumb complete test fix inputs move thumb to env remove extra inputs get thumb from env fix colon env for thumb new step for thumb use with use output fix needs fix needs input the thumb fix thumb fix thumb fix outputs read all fix perms fix perms put publish into reusable workflow fix permissions add push put cache in own workflow set cache permissions add push cache write all constrain delete cache use job id test tenant 2 add sharepoint add exchange add defender fix cache dependencies added all nightly tests - ka-boom! fix lint pass github.job add new inputs fix needs hardcode alias hardcode alias hard card alias add entra fix cache fix bugs in inputs fix issues in other products Fix Checkov Comment out debugging. remove debug, fix checkov fix pipelines runs for the new dirs fix merge conflicts fix checkov suppress checkov error for cache fix lint clean up everything for release to prod Set Defender back to dev params Set Defender back to prod always run variants * change job permissions * fix paths * fix cleanup permissions * fix publish permissions * fix all test permissions * set specific cache permissions * clean up permissions * test permissions for cache * fix needs * remove cache * update job name * Removed or for email when pushing code. * remove comments * change email type * simplify * schedule equal empty * Print Values * fix schedule * fix all if conditions * uncomment * Remove debugging * remove comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Now that the functional tests are passing regularly, it's time to proudly display a badge on the front page of the readme. Actually, I added 2 badges, one for the nightly tests and one for the CI pipeline.
💭 Motivation and context
Closes #883
🧪 Testing
Created test repo, added badge, verified that it worked.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist