-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Conditional Access Policy Implementation Instructions to AAD 1.1 #1312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I reviewed the hyperlink in step 1 and it works fine. For step 2 I verified that the instruction template is accurate and I added some suggested bold to one of the words that you can simply commit if you agree with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the baseline changes and went through the implementation instructions in test tenant to confirm buttonology. Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no additional comments to this update.
2326112
to
b84036f
Compare
@nanda-katikaneni this PR is ready to merge |
7b916e4
to
bc62682
Compare
@nanda-katikaneni I believe this is ready to go. |
🗣 Description
Updated the implementation guide to follow template of other CAP making it easier on user
💭 Motivation and context
closes #982
🧪 Testing
Read the updated verbose, and ensure it is clear and accurate directions
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist