Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Conditional Access Policy Implementation Instructions to AAD 1.1 #1312

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

dagarwal-mitre
Copy link
Collaborator

@dagarwal-mitre dagarwal-mitre commented Sep 10, 2024

🗣 Description

Updated the implementation guide to follow template of other CAP making it easier on user

💭 Motivation and context

closes #982

🧪 Testing

Read the updated verbose, and ensure it is clear and accurate directions

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@dagarwal-mitre dagarwal-mitre added the documentation This issue or pull request improves or adds to documentation label Sep 10, 2024
@dagarwal-mitre dagarwal-mitre added this to the Kraken milestone Sep 10, 2024
@dagarwal-mitre dagarwal-mitre self-assigned this Sep 10, 2024
Copy link
Collaborator

@tkol2022 tkol2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I reviewed the hyperlink in step 1 and it works fine. For step 2 I verified that the instruction template is accurate and I added some suggested bold to one of the words that you can simply commit if you agree with it.

PowerShell/ScubaGear/baselines/aad.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@schrolla schrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the baseline changes and went through the implementation instructions in test tenant to confirm buttonology. Looks good to me.

Copy link
Collaborator

@ahuynhMITRE ahuynhMITRE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no additional comments to this update.

@dagarwal-mitre
Copy link
Collaborator Author

@nanda-katikaneni this PR is ready to merge

@tkol2022
Copy link
Collaborator

@nanda-katikaneni I believe this is ready to go.

@nanda-katikaneni nanda-katikaneni merged commit 4f4233c into main Nov 11, 2024
27 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 982-Enhance-AAD-policy-1.1 branch November 11, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request improves or adds to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance AAD policy 1.1 instructions by including a conditional access policy template
5 participants