Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance AAD provider to handle nested PIM groups and refactor Get-PrivilegedUser to reduce code duplication #1310

Merged
merged 13 commits into from
Sep 26, 2024
Merged

Enhance AAD provider to handle nested PIM groups and refactor Get-PrivilegedUser to reduce code duplication #1310

merged 13 commits into from
Sep 26, 2024

Commits on Sep 24, 2024

  1. added try catch for troubleshooting the source line in Get-Privileged… 

    …User
    @tkol2022 @mitchelbaker-cisa
    tkol2022 authored and mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9612ed8 View commit details
    Browse the repository at this point in the history

  2. changed Get-PrivilegedUser to recursive calls and handled nested grou… 

    …ps assigned to PIM groups
    @tkol2022 @mitchelbaker-cisa
    tkol2022 authored and mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2ba91d6 View commit details
    Browse the repository at this point in the history

  3. Added module dependency Microsoft.Graph.Beta.DirectoryObjects for Get… 

    …-MgBetaDirectoryObject
    @tkol2022 @mitchelbaker-cisa
    tkol2022 authored and mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3303715 View commit details
    Browse the repository at this point in the history

  4. Added 404 handling for deleted users and groups. Added try catch deta… 

    …iled error stacktrace to Get-PrivilegedRole
    @tkol2022 @mitchelbaker-cisa
    tkol2022 authored and mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fb689e1 View commit details
    Browse the repository at this point in the history

  5. line 375 had some evil whitespace and was exorcised

    @tkol2022 @mitchelbaker-cisa
    tkol2022 authored and mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    82af82c View commit details
    Browse the repository at this point in the history

  6. changed write-debug to write-warning

    @tkol2022 @mitchelbaker-cisa
    tkol2022 authored and mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    389fcc5 View commit details
    Browse the repository at this point in the history

  7. added maximum recursion safeguard for nested groups

    @tkol2022 @mitchelbaker-cisa
    tkol2022 authored and mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1e631bb View commit details
    Browse the repository at this point in the history

  8. changed $RoleName parameter to string and wrote first unit test for L… 

    …oadObjectDataIntoPrivilegedUserHashtable
    @tkol2022 @mitchelbaker-cisa
    tkol2022 authored and mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    182a0e5 View commit details
    Browse the repository at this point in the history

  9. fixed flaw in how Recursioncount was incremented and added more unit … 

    …tests
    @tkol2022 @mitchelbaker-cisa
    tkol2022 authored and mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    851c7ee View commit details
    Browse the repository at this point in the history

  10. improved most of the comments and changed incorrect variable name for… 

    … privileged roles from hashtable to array
    @tkol2022 @mitchelbaker-cisa
    tkol2022 authored and mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    29a6421 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. commented out write-warning debug messages for Get-PrivilegedUser

    @tkol2022
    tkol2022 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3a49c49 View commit details
    Browse the repository at this point in the history

  2. removed trailing whitespace

    @tkol2022
    tkol2022 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3944286 View commit details
    Browse the repository at this point in the history

  3. added empty function definitions for ms graph cmdlets that were mocke… 

    …d because it was causing errors since powershell doesn't have the graph modules loaded
    @tkol2022
    tkol2022 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    288cc84 View commit details
    Browse the repository at this point in the history