Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR is one fix of many for Refactor EXO Unit Tests #1111 And other problems with unit tests. One fix for all. #1162

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bosesubham2011
Copy link

Hey Community,

As I am only few hours old of being contributing to open-source. Please provide feedback. I WANT to write unit tests, integration tests for ALL modules of this repo. This PR is one of many.

🗣 Description

Introduces pester for PowerShell unit testing.

💭 Motivation and context

This fixes all issues around Unit tests. I can take up any issue, if someone reaches out.

🧪 Testing

Locally ran and tested the changes. You need to have pester downloaded or added to this repo.

📷 Screenshots (if appropriate)

Uncomment this section if a screenshot is needed.

-->

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@bosesubham2011
Copy link
Author

If this PR is checked and feedback is received, I am ready to take up testing of all the modules.
First complete all unit tests
Integrate with pipeline, so that they are ran at buid time
More discussions to understand the internal flow, so that Mock functions can be written

Integration tests:
This will be the 2nd step
After unit tests are written, we will have a clear understanding of how the functions are behaving
This will also help us fetch any integration between said functions
tests will be written accordingly in Pester.

@buidav buidav added the public-reported This issue is reported by the public users of the tool. label Jun 13, 2024
@adhilto
Copy link
Collaborator

adhilto commented Jun 13, 2024

Hi, thanks for your contribution! We will review this when we can, though I'm not sure what our timeline looks like, as we currently have over 15 PRs in review. Stay tuned for now.

@adhilto adhilto added the Testing This issue or task involves testing the automation tool function label Jun 13, 2024
@bosesubham2011
Copy link
Author

Thanks for your comment. Please take your time, no rush!

@schrolla schrolla added this to the Backlog milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
public-reported This issue is reported by the public users of the tool. Testing This issue or task involves testing the automation tool function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants