Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Llw typos #74

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Llw typos #74

merged 7 commits into from
Nov 28, 2023

Conversation

llwaterhouse
Copy link
Contributor

Fixed some typos.

@llwaterhouse llwaterhouse changed the base branch from main to release-1.1.0-small November 27, 2023 21:24
Copy link
Collaborator

@mreeve-snl mreeve-snl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see changes in this review

docs/markdown/maintenance/upgrading.md Outdated Show resolved Hide resolved
aarz-snl
aarz-snl previously approved these changes Nov 27, 2023
Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, pending Mikey's suggestions for versions

mreeve-snl
mreeve-snl previously approved these changes Nov 28, 2023
Copy link
Collaborator

@mreeve-snl mreeve-snl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also nice changes :)

@llwaterhouse llwaterhouse dismissed mreeve-snl’s stale review November 28, 2023 16:34

The merge-base changed after approval.

Copy link
Collaborator

@mreeve-snl mreeve-snl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mreeve-snl
mreeve-snl previously approved these changes Nov 28, 2023
@llwaterhouse llwaterhouse dismissed mreeve-snl’s stale review November 28, 2023 16:44

The merge-base changed after approval.

cbaxley
cbaxley previously approved these changes Nov 28, 2023
@llwaterhouse llwaterhouse dismissed cbaxley’s stale review November 28, 2023 17:04

The merge-base changed after approval.

mreeve-snl
mreeve-snl previously approved these changes Nov 28, 2023
Copy link
Collaborator

@mreeve-snl mreeve-snl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llwaterhouse llwaterhouse dismissed mreeve-snl’s stale review November 28, 2023 17:10

The merge-base changed after approval.

mreeve-snl
mreeve-snl previously approved these changes Nov 28, 2023
@llwaterhouse llwaterhouse dismissed stale reviews from mreeve-snl and mreeve-snl November 28, 2023 17:15

The merge-base changed after approval.

mreeve-snl
mreeve-snl previously approved these changes Nov 28, 2023
cbaxley
cbaxley previously approved these changes Nov 28, 2023
@llwaterhouse llwaterhouse dismissed cbaxley’s stale review November 28, 2023 17:28

The merge-base changed after approval.

rishagg01
rishagg01 previously approved these changes Nov 28, 2023
@llwaterhouse llwaterhouse dismissed rishagg01’s stale review November 28, 2023 17:41

The merge-base changed after approval.

@ddiabe ddiabe self-requested a review November 28, 2023 17:46
ddiabe
ddiabe previously approved these changes Nov 28, 2023
@llwaterhouse llwaterhouse dismissed ddiabe’s stale review November 28, 2023 17:48

The merge-base changed after approval.

rishagg01
rishagg01 previously approved these changes Nov 28, 2023
@llwaterhouse llwaterhouse dismissed rishagg01’s stale review November 28, 2023 18:06

The merge-base changed after approval.

@llwaterhouse llwaterhouse reopened this Nov 28, 2023
Copy link
Contributor

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, deferring to Mikey and Mitchel's reviews.

@ddiabe ddiabe merged commit 07aa895 into release-1.1.0-small Nov 28, 2023
@llwaterhouse llwaterhouse deleted the llw-typos branch November 28, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

8 participants