Show image pull progress in a separate Echelon node

cirruslabs · Sep 22, 2020 · 9def86d · 9def86d
1 parent 45f73bd
commit 9def86d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/internal/executor/instance/instance.go b/internal/executor/instance/instance.go
@@ -122,12 +122,16 @@ func RunDockerizedAgent(ctx context.Context, config *RunConfig, params *Params)
 	}
 
 	if config.DockerOptions.ShouldPullImage(params.Image) {
-		logger.Debugf("pulling image %s", params.Image)
+		dockerPullLogger := logger.Scoped("docker pull")
+		dockerPullLogger.Infof("Pulling image %s...", params.Image)
 		progress, err := cli.ImagePull(ctx, params.Image, types.ImagePullOptions{})
 		if err != nil {
+			dockerPullLogger.Errorf("Failed to pull %s: %v", params.Image, err)
+			dockerPullLogger.Finish(false)
 			return err
 		}
 		_, err = io.Copy(ioutil.Discard, progress)
+		dockerPullLogger.Finish(err == nil)
 		if err != nil {
 			return err
 		}