Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove \r from file contents when read via USB repl #286

Merged

Conversation

FoamyGuy
Copy link

@ladyada
Resolves: #285

When read via usb repl the file contains both \r\n and the code editor renders both as empty lines. This change strips the \r leaving only a \n to be rendered.

Tested successfully on a locally running instance.
image

@tannewt tannewt requested a review from makermelissa January 22, 2025 17:48
@ladyada
Copy link

ladyada commented Jan 23, 2025

@makermelissa hiya take a look at this one please when yr next working

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I can't remember why I added this before, but if it fixes the issue, then good.

@makermelissa makermelissa merged commit 289b597 into circuitpython:beta Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants