Serial plotter implementation #245
Conversation
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.1 to 5.4.2. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.2/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…m_and_yarn/vite-5.4.2 Bump vite from 5.4.1 to 5.4.2
|
The latest commit resolves the issue of the terminal showing only the top portion of data. We already are using the addon-fit module which handles it perfectly it just needs to be called when the plotter is hidden and shown. So now the most recently printed values are visible within the terminal pane while the plotter is showing. |
…r into plotter.js.
Bumps [sass](https://github.com/sass/dart-sass) from 1.77.8 to 1.78.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.77.8...1.78.0) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…m_and_yarn/sass-1.78.0 Bump sass from 1.77.8 to 1.78.0
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.2 to 5.4.3. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.3/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…m_and_yarn/vite-5.4.3 Bump vite from 5.4.2 to 5.4.3
# Conflicts: # package-lock.json
|
I think the functionality and code for this are ready for review. However I do see that the actions are failing now, and I'm not entirely sure why. The error reported pertains to I found that I got roughly the same error if I run At one point I also accidentally merged I'm sure that it is possible to repair this branch somehow but I feel so far that I've been failing to do so and making it more mucked up. I think it might be easiest for me to just make a new branch started fresh from current beta and open a new PR with it. |
resolves: #244
This is the start of implementing the serial plotter functionality.
It's coming along nicely, here is a screen recording and picture:
Screencast from 2024-08-30 13-02-27.webm
I'm leaving this marked as draft for now though because I do think it still needs some work before being ready. I'm open to any feedback on code or behavior / visual layout.
One of the remaining problems to be solved is that the portion of the terminal that is shown is at the very top of the terminal pane, so as new things are printed they don't actually become visible while the plotter is showing until enough items have been printed to make it scroll enough to actually start showing values. Once they do become visible they are also outdated as well with several newer prints not currently visible below them working to push them up.
I am thinking that it may require changing the number of lines available in the terminal scroll pane while the serial plotter is showing, but haven't explored that further than having the idea yet.
There is probably opportunity to refactor more of the plotter functionality into the new plotter.js file as well.
Right now only the line chart over time is implemented, but there is a commented out dropdown that is intended to eventually allow the user to select scatterplot.