Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file listing for CP 9 #162

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

makermelissa
Copy link
Collaborator

Fixes adafruit/circuitpython#8875. This fixes the connection issue.

@makermelissa makermelissa requested a review from tannewt February 20, 2024 22:39
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now but it's probably better to use the version number because changes in the future may not be as simple.

@makermelissa
Copy link
Collaborator Author

Fair enough. I wanted to just get it fixed so it works in both CP 8 and 9 for the moment. I would like to make better use of the additional info in a future PR and I can have it check the version number at that point.

@makermelissa makermelissa merged commit 1780d47 into circuitpython:main Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to get into web workflow with MatrixPortal S3
2 participants