Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/circonus: Change check fields from TypeSet to TypeList #2

Open
sean- opened this issue Jun 10, 2017 · 0 comments
Open

provider/circonus: Change check fields from TypeSet to TypeList #2

sean- opened this issue Jun 10, 2017 · 0 comments
Assignees

Comments

@sean-
Copy link
Contributor

sean- commented Jun 10, 2017

[ Migrating this issue from hashicorp/terraform#12808 to this repo. ]

The main reason for this change is the following test failure:

=== RUN   TestAccCirconusCheckCloudWatch_basic
--- FAIL: TestAccCirconusCheckCloudWatch_basic (3.22s)
    testing.go:268: Step 0 error: Check failed: Check 5/191 error: circonus_check.rds_metrics: Attribute 'cloudwatch.1637274235.dimmensions.%' not found

but generally speaking if there's TypeSet which is limited to max. 1 item there's (almost) never a reason to keep it as set as there's nothin to sort - no benefit from the hash.

Such change will require state migration also, because some users may already have existing resources in the state under a hash and we'll need to migrate to the new schema (i.e. TypeList, idx = 0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant