Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/circonus: Change check fields from TypeSet to TypeList #3

Closed
hashibot opened this issue Jun 13, 2017 · 1 comment
Closed
Assignees
Labels

Comments

@hashibot
Copy link

This issue was originally opened by @radeksimko as hashicorp/terraform#12808. It was migrated here as part of the provider split. The original body of the issue is below.


The main reason for this change is the following test failure:

=== RUN   TestAccCirconusCheckCloudWatch_basic
--- FAIL: TestAccCirconusCheckCloudWatch_basic (3.22s)
    testing.go:268: Step 0 error: Check failed: Check 5/191 error: circonus_check.rds_metrics: Attribute 'cloudwatch.1637274235.dimmensions.%' not found

but generally speaking if there's TypeSet which is limited to max. 1 item there's (almost) never a reason to keep it as set as there's nothin to sort - no benefit from the hash.

Such change will require state migration also, because some users may already have existing resources in the state under a hash and we'll need to migrate to the new schema (i.e. TypeList, idx = 0).

cc @sean-

@sean-
Copy link
Contributor

sean- commented Jun 15, 2017

Duplicate of #2

@sean- sean- closed this as completed Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants