New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some additional request keys + custom HTTP clients #8

Open

kfyodor wants to merge 1 commit into circleci:master from Qlean:additional-options-and-custom-http-client

kfyodor commented Jul 15, 2016

Hi,

First of all, thanks for the library.

I added some additional API request keys / features I needed for my projects (all changes are backwards-compatible):

ability to pass request, person, framework and context keys to the Items API
ability to use a different HTTP Client (for example, someone might want to use persistent connections etc.)
slightly refactored code responsible for request parameters building, because it became too verbose after adding extra keys.

Hope it's okay!


          ability to use different http client + pass request, person and conte…

9e9982f

…xt params

Contributor

marcomorain commented Jul 15, 2016

Thanks for the PR @konukhov!

I'm not working on Clojure day-to-day anymore - I've asked @conormcd and @gordonsyme to review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet