Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosscompile for JS and Native with scala-yaml as the backend #431

Merged
merged 23 commits into from
Jul 11, 2024

Conversation

sideeffffect
Copy link
Collaborator

@sideeffffect sideeffffect commented May 28, 2024

This is rudimentary support for YAML on JS and Native. We could add much more tests etc., and maybe there are some bugs for edge cases, but this should be fine for the beginning.

Still Scala Native 0.4.x:

This is rudimentary support for YAML on JS and Native. We could add much more tests etc., and maybe there are some bugs for edge cases, but this should be fine for the beginning.
@armanbilge
Copy link

armanbilge commented May 28, 2024

This is rudimentary support for YAML on JS and Native.

See discussions in #186 and #285.

I have already published a library based on the scala-yaml backend and I would be happy to move it to the Circe org. I do not recommend mixing multiple backends in the same repository because that creates issues with versioning and compatibility.

https://github.com/armanbilge/circe-scala-yaml

@sideeffffect
Copy link
Collaborator Author

I think this is fine, making a new repository is not worth it.
We can make further improvements in the scala-yaml backend after the PR is merged.

@sideeffffect
Copy link
Collaborator Author

sideeffffect commented May 29, 2024

Pending bugfix

@sideeffffect
Copy link
Collaborator Author

@sideeffffect sideeffffect merged commit 1c3ad13 into circe:main Jul 11, 2024
9 checks passed
@sideeffffect sideeffffect deleted the scalayaml branch July 11, 2024 11:15
@OndrejSpanel
Copy link

Great to see effort in this direction. It will be great to have a cross platform support.

How would I test 0.15.3, both on JVM and JS? The artifacts are not present in maven (yet?)

@sideeffffect
Copy link
Collaborator Author

The artifacts are already available:
https://repo1.maven.org/maven2/io/circe/circe-yaml-scalayaml_sjs1_3/0.15.3/
https://index.scala-lang.org/circe/circe-yaml/artifacts/circe-yaml-scalayaml

Give them a spin 😉

@OndrejSpanel
Copy link

I did not expect a different library name, but it makes sense - and certainly allows me testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants