Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of maxAliasesForCollections loader option #205

Merged
merged 6 commits into from
Sep 14, 2022

Conversation

hcdeng
Copy link
Collaborator

@hcdeng hcdeng commented May 14, 2021

This addresses #136.

SnakeYaml has maxAliasesForCollections defaulted to 50 in its LoaderOptions. This PR enables customization of this limit, following a similar pattern as Printer, while retaining the current API.

Copy link
Member

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me but ideally we'd also have a sign-off from one of the more core circe-yaml maintainers.

}

object Parser {
val defaultParser = Parser()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of nitpicky, but can we rename this to default (which follows the naming convention in e.g. circe-generic-extras) and put an explicit type annotation on it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, updated

@hcdeng
Copy link
Collaborator Author

hcdeng commented Jul 10, 2021

Thanks @travisbrown ! Would that be @jeffmay or someone else?

@jeffmay
Copy link
Contributor

jeffmay commented Jul 15, 2021

looks like some more scalafmt issues...

@hcdeng
Copy link
Collaborator Author

hcdeng commented Jul 15, 2021

thanks - I think I got them all this time. @jeffmay do you mind kicking off ci again?

@hcdeng
Copy link
Collaborator Author

hcdeng commented Jul 27, 2021

Hi @jeffmay or @travisbrown - can one of you please run CI again? Unfortunately I can't as a first-time contributor.

@hcdeng
Copy link
Collaborator Author

hcdeng commented Jul 27, 2021

Thanks! Looks ready to merge when you get the chance.

@travisbrown
Copy link
Member

I'm publishing an 0.14.1 release right now, but will merge this for the upcoming 0.15 series after that.

@Ushhud
Copy link

Ushhud commented Apr 12, 2022

Hi @travisbrown and @jeffmay, would you be able to merge @hcdeng's changes given that the checks have passed? If so, would you happen to have an ETA on the version and its release?

Thank you!

@travisbrown
Copy link
Member

@Ushhud I am no longer contributing to any Scala open source projects, for the reasons outlined here, but the current Circe maintainers may be able to help.

@jeffmay jeffmay merged commit 6434da6 into circe:master Sep 14, 2022
@sbrnunes
Copy link

Hi @jeffmay, we just ran across this issue as well. Do you have any ETA to release 0.15? I see you merged this to master on September 14, would be great to get this issue released whenever you get the chance. Thank you. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants