-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customization of maxAliasesForCollections loader option #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to me but ideally we'd also have a sign-off from one of the more core circe-yaml maintainers.
} | ||
|
||
object Parser { | ||
val defaultParser = Parser() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of nitpicky, but can we rename this to default
(which follows the naming convention in e.g. circe-generic-extras) and put an explicit type annotation on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, updated
Thanks @travisbrown ! Would that be @jeffmay or someone else? |
looks like some more scalafmt issues... |
thanks - I think I got them all this time. @jeffmay do you mind kicking off ci again? |
Hi @jeffmay or @travisbrown - can one of you please run CI again? Unfortunately I can't as a first-time contributor. |
Thanks! Looks ready to merge when you get the chance. |
I'm publishing an 0.14.1 release right now, but will merge this for the upcoming 0.15 series after that. |
Hi @travisbrown and @jeffmay, would you be able to merge @hcdeng's changes given that the checks have passed? If so, would you happen to have an ETA on the version and its release? Thank you! |
Hi @jeffmay, we just ran across this issue as well. Do you have any ETA to release 0.15? I see you merged this to master on September 14, would be great to get this issue released whenever you get the chance. Thank you. 🙇 |
This addresses #136.
SnakeYaml has maxAliasesForCollections defaulted to 50 in its LoaderOptions. This PR enables customization of this limit, following a similar pattern as Printer, while retaining the current API.